Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline enhancements #3795

Merged
merged 34 commits into from
Oct 6, 2023
Merged

Timeline enhancements #3795

merged 34 commits into from
Oct 6, 2023

Conversation

whitdog47
Copy link
Contributor

@whitdog47 whitdog47 commented Sep 20, 2023 •
edited
Loading

This PR includes many enhancements to the incident timeline, including:

  • Direct link to the timeline for an incident. Users can now browse to .../{org_name}/incidents/{incident_name}/timeline to open the incident view directly to the timeline.
  • The incident details view pane is now expandable by a click and drag on the vertical divider line.
  • Icons in the timeline bubbles quickly indicate the type of event.
  • The incident timeline now has filtering to show/hide different kinds of events, with system events hidden by default.
  • Users can now add custom events to the timeline directly in the UI by hovering between existing events in the timeline and click the "Add event" button.
  • Custom events can be edited and/or deleted by the incident commander or reporter.
  • Messages imported from Slack with the reaction event can now be edited and/or deleted by the incident commander or reporter.

Screenshot 2023-09-20 at 9 27 25 AM

Screenshot 2023-09-20 at 9 43 43 AM

Screenshot 2023-09-20 at 9 42 30 AM

Screenshot 2023-09-22 at 10 32 51 AM

@whitdog47 whitdog47 added the enhancement New feature or request label Sep 20, 2023
@whitdog47 whitdog47 requested a review from wssheldon September 20, 2023 18:49
@wssheldon
Copy link
Contributor

One thing that stands out form a UX perspective in the timeline is user actions vs system actions look very similar. I think it'd help to differentiate them more.

For example, the icon for the user actions could be the users profile picture and names could be bolded/clickable with the user popover component we have.

@wssheldon
Copy link
Contributor

A minor thing from last screenshot -- the delete / edit icons probably fit best positioned all the way right, under the date. that way they wont cover the text or interfere with the content if it is rich (hoverable/clickable) in the future

@whitdog47
Copy link
Contributor Author

One thing that stands out form a UX perspective in the timeline is user actions vs system actions look very similar. I think it'd help to differentiate them more.

For example, the icon for the user actions could be the users profile picture and names could be bolded/clickable with the user popover component we have.

Will pull these ideas into a phase 2, which will align the entire Incident edit/view with the new Case UI.

@whitdog47 whitdog47 marked this pull request as draft September 29, 2023 22:14
@whitdog47 whitdog47 requested a review from jneelamekam October 5, 2023 01:07
@whitdog47 whitdog47 marked this pull request as ready for review October 5, 2023 04:11
@whitdog47 whitdog47 requested a review from wssheldon October 5, 2023 18:23
jneelamekam
jneelamekam approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@jneelamekam jneelamekam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@whitdog47 whitdog47 merged commit 319b2fa into master Oct 6, 2023
8 checks passed
@whitdog47 whitdog47 deleted the enhancement/direct-link-to-timeline branch October 6, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneelamekam jneelamekam jneelamekam approved these changes

@wssheldon wssheldon Awaiting requested review from wssheldon

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whitdog47 @wssheldon @jneelamekam